lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Wed, 6 Dec 2017 18:27:25 +0100
From:   Peter Rosin <peda@...ntia.se>
To:     Bartosz Golaszewski <brgl@...ev.pl>
Cc:     Uwe Kleine-K├Ânig <u.kleine-koenig@...gutronix.de>,
        linux-i2c <linux-i2c@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 2/2] eeprom: at24: use a common prefix for all symbols
 in at24.c

On 2017-12-06 15:29, Bartosz Golaszewski wrote:
> 2017-12-06 14:40 GMT+01:00 Peter Rosin <peda@...ntia.se>:
>> Hi!
>>
>> Some nits...
>>
>> On 2017-12-06 14:01, Bartosz Golaszewski wrote:
>>> There are a couple symbols defined in the driver source file which are
>>> missing the at24_ prefix. This patch fixes that.
>>>
>>> For module params: use module_param_named() in order not to break the
>>> userspace.
>>
>> I'd write that as "...in order to not break userspace"
>>
> 
> I would love to hear an English native speaker's opinion on that. :)

"not to" or "to not" is a matter of style/taste. I mainly wanted to point
out that the definite article of "userspace" should be removed, because
you are not talking about one particular userspace.

Cheers,
peda

Powered by blists - more mailing lists