linux-kernel - Re: [PATCH v8 2/2] ARM: dts: TS-4600: add basic device tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1f11151e-fa71-5af6-245d-482fcbcec5e9@savoirfairelinux.com>
Date:   Thu, 7 Dec 2017 12:06:11 -0500
From:   Sebastien Bourdelin <sebastien.bourdelin@...oirfairelinux.com>
To:     Fabio Estevam <festevam@...il.com>
Cc:     linux-kernel <linux-kernel@...r.kernel.org>,
        kernel@...oirfairelinux.com,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        Fabio Estevam <fabio.estevam@....com>,
        Sascha Hauer <kernel@...gutronix.de>,
        Shawn Guo <shawnguo@...nel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        Mark Rutland <mark.rutland@....com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        Mark Featherston <mark@...eddedarm.com>, kris@...eddedarm.com
Subject: Re: [PATCH v8 2/2] ARM: dts: TS-4600: add basic device tree

Hi Fabio

On 11/26/2017 02:39 PM, Fabio Estevam wrote:
> Hi Sebastien,
> 
> On Thu, Nov 23, 2017 at 7:04 PM, Sebastien Bourdelin
> <sebastien.bourdelin@...oirfairelinux.com> wrote:
> 
>> +       reg_vddio_sd0: regulator-vddio-sd0 {
>> +               compatible = "regulator-fixed";
>> +               regulator-name = "vddio-sd0";
>> +               regulator-min-microvolt = <3300000>;
>> +               regulator-max-microvolt = <3300000>;
>> +               regulator-boot-on;
>> +               gpio = <&gpio3 28 GPIO_ACTIVE_HIGH>;
> 
> It seems this should be GPIO_ACTIVE_LOW instead, as you don't pass
> 'enable-active-high' here.
> 

Yes! you are right, thanks for the catch!

Regards,
Sebastien.