lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <7ho9nbmked.fsf@baylibre.com> Date: Wed, 06 Dec 2017 16:50:02 -0800 From: Kevin Hilman <khilman@...libre.com> To: Yixun Lan <yixun.lan@...ogic.com> Cc: Neil Armstrong <narmstrong@...libre.com>, Jerome Brunet <jbrunet@...libre.com>, Rob Herring <robh+dt@...nel.org>, Mark Rutland <mark.rutland@....com>, Michael Turquette <mturquette@...libre.com>, Stephen Boyd <sboyd@...eaurora.org>, Carlo Caione <carlo@...one.org>, Qiufang Dai <qiufang.dai@...ogic.com>, <linux-amlogic@...ts.infradead.org>, <devicetree@...r.kernel.org>, <linux-clk@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>, <linux-kernel@...r.kernel.org> Subject: Re: [PATCH v4 4/4] arm64: dts: meson-axg: add clock DT info for Meson AXG SoC Yixun Lan <yixun.lan@...ogic.com> writes: > From: Qiufang Dai <qiufang.dai@...ogic.com> > > Try to add Hiubus DT info, and also enable clock DT info > for the Amlogic's Meson-AXG SoC. > > Acked-by: Rob Herring <robh@...nel.org> > Signed-off-by: Qiufang Dai <qiufang.dai@...ogic.com> > Signed-off-by: Yixun Lan <yixun.lan@...ogic.com> > --- > arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi > index b932a784b02a..36a2e98338a8 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi > +++ b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi > @@ -7,6 +7,7 @@ > #include <dt-bindings/gpio/gpio.h> > #include <dt-bindings/interrupt-controller/irq.h> > #include <dt-bindings/interrupt-controller/arm-gic.h> > +#include <dt-bindings/clock/axg-clkc.h> This #include will cause an unnessary dependency from the amlogic tree to the clock tree even though this patch is not currently using any of the #defines from that header. It will simplify the dependencies if you drop this #include from this patch. In my comment on the cover letter, I suggested adding a patch that also switches the UART over to the new clock provider. That is the patch that should add this #include, since it will actually need #defines from the header. Doing it in that order means that we could merge this patch independently of the clock driver, and then merge the UART switch-over patch only after the driver (and headers) are merged. Kevin
Powered by blists - more mailing lists