linux-kernel - Re: [PATCH] platform/x86: intel-vbtn: Simplify autorelease logic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7546133.vVTS3nG8Ku@pebbles>
Date:   Sat, 9 Dec 2017 00:28:18 +0100
From:   Stefan Brüns <stefan.bruens@...h-aachen.de>
To:     "Darren Hart (VMware)" <dvhart@...radead.org>
CC:     <platform-driver-x86@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        AceLan Kao <acelan.kao@...onical.com>,
        "Andy Shevchenko" <andriy.shevchenko@...ux.intel.com>
Subject: Re: [PATCH] platform/x86: intel-vbtn: Simplify autorelease logic

On Saturday, December 9, 2017 12:07:08 AM CET Darren Hart (VMware) wrote:
> The new notify_handler logic determining if autorelease should be used or
> not is a bit awkward, and can result in more than one call to
> sparse_keymap_report_event for the same event (scancode). The nesting
> and long lines also made it difficult to read.
> 
> Simplify the logic by eliminating a level of nesting with a goto and
> always calculate autorelease and val so we can make a single call to
> sparse_keymap_report_event.
> 
> Signed-off-by: Darren Hart (VMware) <dvhart@...radead.org>
> Cc: Stefan Brüns <stefan.bruens@...h-aachen.de>
> Cc: AceLan Kao <acelan.kao@...onical.com>
> ---
> Note: This is based on top of Stefan's v2 patch series for intel-vbtn,
> currently in my review-dvhart branch.

Hi Darren,

is this tree publically available?

Thanks,

Stefan

-- 
Stefan Brüns  /  Bergstraße 21  /  52062 Aachen
home: +49 241 53809034     mobile: +49 151 50412019
Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)