lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <12a4228d-ab5e-35e4-a65c-24b0e64b1300@gmail.com> Date: Fri, 8 Dec 2017 15:28:53 -0800 From: Florian Fainelli <f.fainelli@...il.com> To: Bjorn Helgaas <helgaas@...nel.org>, Jim Quinlan <jim2101024@...il.com> Cc: linux-kernel@...r.kernel.org, Bjorn Helgaas <bhelgaas@...gle.com>, Catalin Marinas <catalin.marinas@....com>, Will Deacon <will.deacon@....com>, Rob Herring <robh+dt@...nel.org>, Brian Norris <computersforpeace@...il.com>, Russell King <rmk+kernel@...linux.org.uk>, Robin Murphy <robin.murphy@....com>, Christoph Hellwig <hch@....de>, Florian Fainelli <f.fainelli@...il.com>, Jonas Gorski <jonas.gorski@...il.com>, Mark Rutland <mark.rutland@....com>, devicetree@...r.kernel.org, linux-mips@...ux-mips.org, linux-pci@...r.kernel.org, Kevin Cernekee <cernekee@...il.com>, Ralf Baechle <ralf@...ux-mips.org>, bcm-kernel-feedback-list@...adcom.com, Gregory Fong <gregory.0xf0@...il.com>, linux-arm-kernel@...ts.infradead.org Subject: Re: [PATCH v3 1/8] SOC: brcmstb: add memory API On 12/05/2017 12:59 PM, Bjorn Helgaas wrote: > On Tue, Nov 14, 2017 at 05:12:05PM -0500, Jim Quinlan wrote: >> From: Florian Fainelli <f.fainelli@...il.com> >> >> This commit adds a memory API suitable for ascertaining the sizes of >> each of the N memory controllers in a Broadcom STB chip. Its first >> user will be the Broadcom STB PCIe root complex driver, which needs >> to know these sizes to properly set up DMA mappings for inbound >> regions. >> >> We cannot use memblock here or anything like what Linux provides >> because it collapses adjacent regions within a larger block, and here >> we actually need per-memory controller addresses and sizes, which is >> why we resort to manual DT parsing. >> >> Signed-off-by: Jim Quinlan <jim2101024@...il.com> >> --- >> drivers/soc/bcm/brcmstb/Makefile | 2 +- >> drivers/soc/bcm/brcmstb/memory.c | 172 +++++++++++++++++++++++++++++++++++++++ >> include/soc/brcmstb/memory_api.h | 25 ++++++ >> 3 files changed, 198 insertions(+), 1 deletion(-) >> create mode 100644 drivers/soc/bcm/brcmstb/memory.c >> create mode 100644 include/soc/brcmstb/memory_api.h >> >> diff --git a/drivers/soc/bcm/brcmstb/Makefile b/drivers/soc/bcm/brcmstb/Makefile >> index 9120b27..4cea7b6 100644 >> --- a/drivers/soc/bcm/brcmstb/Makefile >> +++ b/drivers/soc/bcm/brcmstb/Makefile >> @@ -1 +1 @@ >> -obj-y += common.o biuctrl.o >> +obj-y += common.o biuctrl.o memory.o >> diff --git a/drivers/soc/bcm/brcmstb/memory.c b/drivers/soc/bcm/brcmstb/memory.c >> new file mode 100644 >> index 0000000..eb647ad9 >> --- /dev/null >> +++ b/drivers/soc/bcm/brcmstb/memory.c > > I sort of assume based on [1] that every new file should have an SPDX > identifier ("The Linux kernel requires the precise SPDX identifier in > all source files") and that the actual text of the GPL can be omitted. > > Only a few files in drivers/pci currently have an SPDX identifier. I > don't know if that's oversight or work-in-progress or what. > > [1] https://lkml.kernel.org/r/20171204212120.484179273@linutronix.de This was submitted before SPDX was consistently enforced tree wide, so yes we should fix this. Any other comment besides that? -- Florian
Powered by blists - more mailing lists