linux-kernel - Re: [PATCH 1/2] tools/lib/lockdep: Add missing declaration of 'pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171208061913.4pvol2tezybgbdzr@gmail.com>
Date:   Fri, 8 Dec 2017 07:19:13 +0100
From:   Ingo Molnar <mingo@...nel.org>
To:     alexander.levin@...izon.com
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] tools/lib/lockdep: Add missing declaration of
 'pr_cont()'


* alexander.levin@...izon.com <alexander.levin@...izon.com> wrote:

> From: Mengting Zhang <zhangmengting@...wei.com>
> 
> An annoying compile warning due to missing declaration is shown below:
> In file included from lockdep.c:27:0:
> ../../../kernel/locking/lockdep.c: In function 'print_unlock_imbalance_bug' :
> ../../../kernel/locking/lockdep.c:3544:2: warning: implicit declaration of function 'pr_cont' [-Wimplicit-function-declaration]
>   pr_cont(") at:\n");
>   ^

All build warnings are annoying, please formulate this in a more neutral fashion.

Also, please separate the compiler splat from the changelog text with an empty 
line, and align it vertically as well so that it seprates more.

Please do this for the second patch as well, and try to harmonize the style of the 
changelogs.

This is an example of a clean changelog that fixes a build warning:

commit 1b3b5219abfd6a214e99018747e9fe98514b43ca
Author: Arnaldo Carvalho de Melo <acme@...hat.com>
Date:   Mon Nov 27 12:18:23 2017 -0300

    tools headers: Syncronize mman.h ABI header
    
    To add support for the MAP_SYNC flag introduced in:
    
      b6fb293f2497 ("mm: Define MAP_SYNC and VM_SYNC flags")
    
    Update tools/perf/trace/beauty/mmap.c to support that flag.
    
    This silences this perf build warning:
    
      Warning: Kernel ABI header at 'tools/include/uapi/asm-generic/mman.h' differs from latest version at 'include/uapi/asm-generic/mman.h'
    
    Cc: Adrian Hunter <adrian.hunter@...el.com>
    Cc: Dan Williams <dan.j.williams@...el.com>
    Cc: David Ahern <dsahern@...il.com>
    Cc: Jan Kara <jack@...e.cz>
    Cc: Jiri Olsa <jolsa@...nel.org>
    Cc: Namhyung Kim <namhyung@...nel.org>
    Cc: Wang Nan <wangnan0@...wei.com>
    Link: https://lkml.kernel.org/n/tip-14zyk3iywrj37c7g1eagmzbo@git.kernel.org
    Signed-off-by: Arnaldo Carvalho de Melo <acme@...hat.com>

Thanks,

	Ingo