linux-kernel - Re: [PATCH 2/2] tools/lib/lockdep: add empty declaration for early

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171208062010.yrcbazicfut7pmk2@gmail.com>
Date:   Fri, 8 Dec 2017 07:20:10 +0100
From:   Ingo Molnar <mingo@...nel.org>
To:     alexander.levin@...izon.com
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Peter Zijlstra <a.p.zijlstra@...llo.nl>
Subject: Re: [PATCH 2/2] tools/lib/lockdep: add empty declaration for
 early_param


* Ingo Molnar <mingo@...nel.org> wrote:

> 
> * alexander.levin@...izon.com <alexander.levin@...izon.com> wrote:
> 
> > Fixes a compilation error:
> > 
> >   CC       lockdep.o
> > In file included from lockdep.c:28:0:
> > ../../../kernel/locking/lockdep.c:89:13: error: expected declaration specifiers or ‘...’ before string constant
> >  early_param("crossrelease_fullstack", allow_crossrelease_fullstack);
> >              ^~~~~~~~~~~~~~~~~~~~~~~~
> > ../../../kernel/locking/lockdep.c:89:39: error: expected declaration specifiers or ‘...’ before ‘allow_crossrelease_fullstack’
> >  early_param("crossrelease_fullstack", allow_crossrelease_fullstack);
> >                                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> Ugh, this changelog was in DOS format (had extra \r's) - how did that happen?

Hm, so it's because the second patch email was sent as as a base64 encoded email:

  Content-Transfer-Encoding: base64

totally not recommended and git-send-email will not do that - what happened?

> 
> Fixed it up.

Actually, could you please resend the whole series, with a fix for the other 
warning I reported added, with the changelogs fixed, and not MIME encoded?

Thanks,

	Ingo