linux-kernel - Re: [PATCH v2] usb: dwc2: Remove unnecessary debug prints

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8729999BB856DC46AF55C3A0E7F336B52F99B6D7@am04wembxa.internal.synopsys.com>
Date:   Fri, 8 Dec 2017 07:55:33 +0000
From:   Razmik Karapetyan <Razmik.Karapetyan@...opsys.com>
To:     Joe Perches <joe@...ches.com>,
        Razmik Karapetyan <Razmik.Karapetyan@...opsys.com>,
        John Youn <John.Youn@...opsys.com>,
        Felipe Balbi <balbi@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] usb: dwc2: Remove unnecessary debug prints

On 12/7/2017 11:18 PM, Joe Perches wrote:
> On Thu, 2017-12-07 at 11:17 -0800, Joe Perches wrote:
>> On Wed, 2017-12-06 at 17:57 +0400, Razmik Karapetyan wrote:
>>> Removed unnecessary debug prints about DMA mode for host side
>>> from dwc2_gahbcfg_init() function.
>>
>> What other functionality makes these unnecessary?
>> If any, it's nice to de
> 
> ... describe it in the changelog.
> 

Hi Joe,

No any other functionality makes them unnecessary.

In the driver we have debug info about DMA type only for host side, so 
operating in device mode DMA type can be different and those debug 
prints ("Using Buffer\Descriptor DMA mode\n") can cause confusions.

We can add debug prints for device mode also, but it is preferable to 
have less debug info in the log.

Thanks,
Razmik