lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Fri, 8 Dec 2017 15:54:54 +0800
From:   Jason Yan <>
To:     Cong Wang <>,
        John Garry <>
CC:     Johannes Thumshirn <>,
        LKML <>,
        Dan Williams <>,
        Praveen Murali <>,
        "James E.J. Bottomley" <>,
        "Martin K. Petersen" <>,
        "" <>,
        chenxiang <>
Subject: Re: [PATCH] libsas: flush pending destruct work in

On 2017/12/8 6:57, Cong Wang wrote:
> On Thu, Dec 7, 2017 at 5:37 AM, John Garry <> wrote:
>> On 28/11/2017 17:04, Cong Wang wrote:
>>> I don't understand, the only caller of sas_unregister_domain_devices()
>>> is sas_deform_port().
>> And sas_deform_port() may be called from another worker on the same queue,
>> right? As in sas_phye_loss_of_signal()->sas_deform_port()
> Oh, good catch! I didn't notice this subtle call path.
> Do you have any better idea to fix this? We saw this on 4.9 too.

We have sent a patchset to fix this and to enhance libsas hotplug.
Please refer to

And I'm going to send a new version soon.


>> The device destruct takes place in a separate worker from which
>> sas_deform_port() is called, but the same queue. So we have this queued
>> destruct happen after the port is fully deformed -> hence the WARN.
>> I guess you only tested your patch on disks attached through an expander.
> I have very limited scsi hardware, so my testing is limited too.
> .

Powered by blists - more mailing lists