linux-kernel - Re: [PATCH/RFC] DT: leds: Fix 'label' property description and add 'colour' property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1c741846-63d3-f940-4888-1b1899147ab0@ti.com>
Date:   Fri, 8 Dec 2017 10:01:45 -0600
From:   Dan Murphy <dmurphy@...com>
To:     Jacek Anaszewski <jacek.anaszewski@...il.com>,
        <linux-leds@...r.kernel.org>, <linux-kernel@...r.kernel.org>
CC:     <robh@...nel.org>, <pavel@....cz>, <sakari.ailus@....fi>
Subject: Re: [PATCH/RFC] DT: leds: Fix 'label' property description and add
 'colour' property

Jacek

On 12/02/2017 03:50 PM, Jacek Anaszewski wrote:
> Label property was imposed a uniqueness requirement, which was erroneous,
> since ePAPR defines it to "a human readable string describing a device".
> 
> Also the binding description misleadingly suggested direct usage of label
> for LED class device name, whereas it should only define a LED function.
> 
> Therefore an additional 'colour' property is being introduced, which together
> with the parent DT node name used for devicename shall be used for naming LED
> class device according to the patterh <devicename>:<colour>:<function>.
> 

In submitting updated DT bindings the maintainers are requesting all device parent
LED nodes be 

leds@xx {

Now this will make every LED class devicename

leds:<colour>:<function>

So either we cannot use the devicename or we need need to use the compatible string instead.

So an example would be

ti,lp8860:white:backlight

You should be on these patches.

Dan

> Fixes: 116b8e164116 ("DT: leds: Add uniqueness requirement for 'label' property")
> Signed-off-by: Jacek Anaszewski <jacek.anaszewski@...il.com>
> ---
>  Documentation/devicetree/bindings/leds/common.txt | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/leds/common.txt b/Documentation/devicetree/bindings/leds/common.txt
> index 1d4afe9..16973ee 100644
> --- a/Documentation/devicetree/bindings/leds/common.txt
> +++ b/Documentation/devicetree/bindings/leds/common.txt
> @@ -14,10 +14,9 @@ Optional properties for child nodes:
>  - led-sources : List of device current outputs the LED is connected to. The
>  		outputs are identified by the numbers that must be defined
>  		in the LED device binding documentation.
> -- label : The label for this LED. If omitted, the label is taken from the node
> -	  name (excluding the unit address). It has to uniquely identify
> -	  a device, i.e. no other LED class device can be assigned the same
> -	  label.
> +- label : The label for this LED. It should describe its function. If omitted,
> +          the label is taken from the node name (excluding the unit address).
> +- colour : Colour of the LED.
>  
>  - default-state : The initial state of the LED. Valid values are "on", "off",
>    and "keep". If the LED is already on or off and the default-state property is
> 


-- 
------------------
Dan Murphy