linux-kernel - Re: [PATCH net-next] libbpf: add function to setup XDP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <446f0215-542c-d482-109b-20149a7ff28f@gmail.com>
Date:   Sat, 9 Dec 2017 09:34:46 -0700
From:   David Ahern <dsahern@...il.com>
To:     Eric Leblond <eric@...it.org>, netdev@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, ast@...nel.org, daniel@...earbox.net
Subject: Re: [PATCH net-next] libbpf: add function to setup XDP

On 12/9/17 7:43 AM, Eric Leblond wrote:
> +	/* started nested attribute for XDP */
> +	nla = (struct nlattr *)(((char *)&req)
> +				+ NLMSG_ALIGN(req.nh.nlmsg_len));
> +	nla->nla_type = NLA_F_NESTED | 43/*IFLA_XDP*/;

as a part of the move into libbpf can the magic numbers be replaced by
the names directly and there as a comment?

There are more below.


> +	nla->nla_len = NLA_HDRLEN;
> +
> +	/* add XDP fd */
> +	nla_xdp = (struct nlattr *)((char *)nla + nla->nla_len);
> +	nla_xdp->nla_type = 1/*IFLA_XDP_FD*/;
> +	nla_xdp->nla_len = NLA_HDRLEN + sizeof(int);
> +	memcpy((char *)nla_xdp + NLA_HDRLEN, &fd, sizeof(fd));
> +	nla->nla_len += nla_xdp->nla_len;
> +
> +	/* if user passed in any flags, add those too */
> +	if (flags) {
> +		nla_xdp = (struct nlattr *)((char *)nla + nla->nla_len);
> +		nla_xdp->nla_type = 3/*IFLA_XDP_FLAGS*/;
> +		nla_xdp->nla_len = NLA_HDRLEN + sizeof(flags);
> +		memcpy((char *)nla_xdp + NLA_HDRLEN, &flags, sizeof(flags));
> +		nla->nla_len += nla_xdp->nla_len;
> +	}
> +