linux-kernel - Re: [PATCH] doc: convert printk-formats.txt to rst

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGXu5jLS6TpSTj48bOpQqHmqvoAtY38wT0+s49yjnZZm1Q2zhg@mail.gmail.com>
Date:   Sun, 10 Dec 2017 16:51:15 -0800
From:   Kees Cook <keescook@...omium.org>
To:     Dan Carpenter <dan.carpenter@...cle.com>,
        Rasmus Villemoes <linux@...musvillemoes.dk>
Cc:     Joe Perches <joe@...ches.com>, "Tobin C. Harding" <me@...in.cc>,
        Dan Carpenter <error27@...il.com>,
        Laura Abbott <labbott@...hat.com>,
        Jonathan Corbet <corbet@....net>,
        Randy Dunlap <rdunlap@...radead.org>,
        linux-doc@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] doc: convert printk-formats.txt to rst

On Sat, Dec 9, 2017 at 3:48 AM, Dan Carpenter <dan.carpenter@...cle.com> wrote:
> On Fri, Dec 08, 2017 at 06:18:45PM -0800, Joe Perches wrote:
>> On Sat, 2017-12-09 at 12:27 +1100, Tobin C. Harding wrote:
>> > On Fri, Dec 08, 2017 at 01:22:37PM -0800, Joe Perches wrote:
>>
>> > > Outside of the documentation, what could be useful is for
>> > > someone to add a tool to verify %p<foo> extension to
>> > > the typeof address actually passed as an argument.
>> >
>> > This sounds interesting to work no. At first glance I have no idea how
>> > one would go about this. Some form of static analysis would be a good
>> > place to start, right? I'd like to allocate some cycles to this, any
>> > pointers most appreciated.
>>
>> A gcc-plugin would likely work best.
>>
>> There was some discussion about such a thing here:
>> http://www.openwall.com/lists/kernel-hardening/2017/02/14/38
>>
>> I vaguely recall someone else doing a broader use tool
>> which I believe was not smatch, but my google-fu isn't
>> finding it.
>
> Yeah.  Smatch has a check for this.  Rasmus Villemoes wrote it.

There's been some other work on format strings by Rasmus too. Thread
is here, which I still haven't caught back up on:

http://www.openwall.com/lists/kernel-hardening/2017/11/08/25

-Kees

-- 
Kees Cook
Pixel Security