linux-kernel - Re: [PATCH 2/3] regmap: don't create the debugfs entries if locking is disabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMRc=MdyF3axnh60VYnjrTJDvWH2Jx12=-m2FnnxaAPmp7sf=w@mail.gmail.com>
Date:   Wed, 13 Dec 2017 16:46:10 +0100
From:   Bartosz Golaszewski <brgl@...ev.pl>
To:     Mark Brown <broonie@...nel.org>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Andy Shevchenko <andy.shevchenko@...il.com>
Subject: Re: [PATCH 2/3] regmap: don't create the debugfs entries if locking
 is disabled

2017-12-13 16:39 GMT+01:00 Mark Brown <broonie@...nel.org>:
> On Wed, Dec 13, 2017 at 10:28:11AM +0100, Bartosz Golaszewski wrote:
>> User space can initiate concurrent access to regmap over debugfs and,
>> if the locking is disabled, we can't protect it. Don't create the
>> debugfs entries at all in this case.
>
> I (probably unsurprisingly) prefer my version that I posted yesterday as
> it gives us the trivial memory saving of not having the flag if debugfs
> is disabled but more importantly from my point of view keeps the
> interface to debugfs as function calls in the core.

It went into spam in my mailbox for some reason, that's why I didn't see it.

Yes, it looks better. I'll drop it from the series.

Thanks,
Bartosz