linux-kernel - Re: [RFC PATCH 1/2] ASoC: add support of mclk clock providers in wm8894 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171214173025.GL9788@sirena.org.uk>
Date:   Thu, 14 Dec 2017 17:30:25 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Olivier Moysan <olivier.moysan@...com>
Cc:     lgirdwood@...il.com, perex@...ex.cz, tiwai@...e.com,
        mcoquelin.stm32@...il.com, alexandre.torgue@...com,
        alsa-devel@...a-project.org, linux-arm-kernel@...ts.infradead.org,
        kernel@...inux.com, linux-kernel@...r.kernel.org,
        arnaud.pouliquen@...com, benjamin.gaignard@...com,
        patches@...nsource.wolfsonmicro.com
Subject: Re: [RFC PATCH 1/2] ASoC: add support of mclk clock providers in
 wm8894 driver

On Thu, Dec 14, 2017 at 05:53:57PM +0100, Olivier Moysan wrote:

> +	pdata->mclk1 = devm_clk_get(wm8994->dev, "MCLK1");
> +	if (IS_ERR(pdata->mclk1))
> +		pdata->mclk1 = NULL;

These should special case -EPROBE_DEFER so we defer properly if we need
to (and ideally log an error in case there was a MCLK and we legit ran
into an error).

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)