linux-kernel - Re: [RFC PATCH 2/2] ASoC: select sysclk clock from mlck clock provider in wm8994 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171214173624.GM9788@sirena.org.uk>
Date:   Thu, 14 Dec 2017 17:36:24 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Olivier Moysan <olivier.moysan@...com>
Cc:     lgirdwood@...il.com, perex@...ex.cz, tiwai@...e.com,
        mcoquelin.stm32@...il.com, alexandre.torgue@...com,
        alsa-devel@...a-project.org, linux-arm-kernel@...ts.infradead.org,
        kernel@...inux.com, linux-kernel@...r.kernel.org,
        arnaud.pouliquen@...com, benjamin.gaignard@...com,
        patches@...nsource.wolfsonmicro.com
Subject: Re: [RFC PATCH 2/2] ASoC: select sysclk clock from mlck clock
 provider in wm8994 driver

On Thu, Dec 14, 2017 at 05:53:58PM +0100, Olivier Moysan wrote:
> When defined in device tree, MCLK1 and MCLK2 are used
> as sysclk for aif1 and aif2 interfaces respectively.

That's not a valid assumption as far as I remember?  The AIFs can use
either MCLK depending on the system configuration I think.

> If clock rate is let 0, the frequency provided by
> wm8994_set_dai_sysclk() is used instead.

I'd expect this the other way around, if we didn't specify a frequency
then read it from the input otherwise try to use clk_set_rate() to
propagate things up.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)