linux-kernel - Re: [PATCH] platform/x86: dell-wmi-aio: Block comments use * on subsequent lines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 14 Dec 2017 19:58:35 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Dhaval Shah <dhaval.shah@...tnautics.com>
Cc:     "dvhart@...radead.org" <dvhart@...radead.org>,
        Andy Shevchenko <andy@...radead.org>,
        Platform Driver <platform-driver-x86@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] platform/x86: dell-wmi-aio: Block comments use * on
 subsequent lines

On Wed, Dec 13, 2017 at 10:18 AM, Dhaval Shah
<dhaval.shah@...tnautics.com> wrote:
> Resolved Block comments use * on subsequent lines checkpatch warnings.
> Issue found by checkpatch.

// indeed will look better in these cases.

Please, get blessing from author(s) / maintainer(s) of the module
first before sending any patches like this.

>
> Signed-off-by: Dhaval Shah <dhaval.shah@...tnautics.com>
> ---
>  drivers/platform/x86/dell-wmi-aio.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/platform/x86/dell-wmi-aio.c b/drivers/platform/x86/dell-wmi-aio.c
> index 50c2078715d6..3842b32a729c 100644
> --- a/drivers/platform/x86/dell-wmi-aio.c
> +++ b/drivers/platform/x86/dell-wmi-aio.c
> @@ -36,7 +36,8 @@ MODULE_LICENSE("GPL");
>  struct dell_wmi_event {
>         u16     length;
>         /* 0x000: A hot key pressed or an event occurred
> -        * 0x00F: A sequence of hot keys are pressed */
> +        * 0x00F: A sequence of hot keys are pressed
> +        */
>         u16     type;
>         u16     event[];
>  };
> @@ -115,7 +116,8 @@ static void dell_wmi_aio_notify(u32 value, void *context)
>                                 scancode = event->event[0];
>                         } else {
>                                 /* Broken machines return the scancode in a
> -                                  buffer */
> +                                * buffer
> +                                */
>                                 if (obj->buffer.pointer &&
>                                                 obj->buffer.length > 0)
>                                         scancode = obj->buffer.pointer[0];
> --
> 2.11.0
>



-- 
With Best Regards,
Andy Shevchenko