linux-kernel - Re: [PATCH v4 4/6] dt: bindings: lp8860: Add trigger binding to the lp8860

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <76329432-f96e-93ab-ed9b-ade22c8735c9@ti.com>
Date:   Fri, 15 Dec 2017 11:22:24 -0600
From:   Dan Murphy <dmurphy@...com>
To:     Pavel Machek <pavel@....cz>
CC:     <robh+dt@...nel.org>, <mark.rutland@....com>, <rpurdie@...ys.net>,
        <jacek.anaszewski@...il.com>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <linux-leds@...r.kernel.org>
Subject: Re: [PATCH v4 4/6] dt: bindings: lp8860: Add trigger binding to the
 lp8860

Pavel

On 12/15/2017 03:09 AM, Pavel Machek wrote:
> Hi!
> 
>> @@ -35,6 +37,7 @@ led-controller@2d {
>>  	led@0 {
>>  		reg = <0>;
>>  		label = "white:display_cluster";
>> +		linux,default-trigger = "backlight";
>>  	};
>>  }
> 
> What is "display_cluster"? Is it display backlight?
> 

This device can be configured to drive all 4 LED strings in display mode
so that all 4 strings have the same brightness controlled either through PWM or
through the brightness register 

or

As cluster string where the brightness of individual strings or clustered strings
can be controlled via independent brightness control registers.  I am currently working
on adding this support to the driver.

Dan

> Could we use ":backlight" and perhaps start documentation file listing
> "common" LED descriptions so they are shared across machines?
> 
> For the record, I'd prefer this to be
> "/sys/class/leds/display:white:backlight" in the end... so that we
> have nice naming for userspace, consistent between different machines.
> 
> 									Pavel
> 


-- 
------------------
Dan Murphy