linux-kernel - Re: [PATCH v4 4/6] dt: bindings: lp8860: Add trigger binding to the lp8860

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 15 Dec 2017 10:09:03 +0100
From:   Pavel Machek <pavel@....cz>
To:     Dan Murphy <dmurphy@...com>
Cc:     robh+dt@...nel.org, mark.rutland@....com, rpurdie@...ys.net,
        jacek.anaszewski@...il.com, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-leds@...r.kernel.org
Subject: Re: [PATCH v4 4/6] dt: bindings: lp8860: Add trigger binding to the
 lp8860

Hi!

> @@ -35,6 +37,7 @@ led-controller@2d {
>  	led@0 {
>  		reg = <0>;
>  		label = "white:display_cluster";
> +		linux,default-trigger = "backlight";
>  	};
>  }

What is "display_cluster"? Is it display backlight?

Could we use ":backlight" and perhaps start documentation file listing
"common" LED descriptions so they are shared across machines?

For the record, I'd prefer this to be
"/sys/class/leds/display:white:backlight" in the end... so that we
have nice naming for userspace, consistent between different machines.

									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)