linux-kernel - Re: [PATCH] xen/balloon: Mark unallocated host memory as UNUSABLE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1385e130-7300-66a4-3995-838244600746@suse.com>
Date:   Fri, 15 Dec 2017 15:47:19 +0100
From:   Juergen Gross <jgross@...e.com>
To:     Boris Ostrovsky <boris.ostrovsky@...cle.com>,
        xen-devel@...ts.xen.org, linux-kernel@...r.kernel.org
Cc:     helgaas@...nel.org, christian.koenig@....com
Subject: Re: [PATCH] xen/balloon: Mark unallocated host memory as UNUSABLE

On 15/12/17 15:24, Boris Ostrovsky wrote:
> 
>>> +
>>> +	hostmem_resource->start = max_addr;
>>> +	hostmem_resource->end = entry->addr + entry->size;
>>> +	for (; i < memmap.nr_entries; i++) {
>>> +		entry = &xen_e820_table->entries[i];
>>> +		if (entry->type == E820_TYPE_RAM)
>> Shouldn't that be != ?
> 
> No, the idea here is to populate hostmem_resource with ranges already
> taken by things other than RAM, leaving memory regions as available for
> the balloon hotplug. This will allow us to use allocate_resource(),
> which searches for a free range, in the balloon driver.

But why says the comment "Host memory not allocated to dom0" then?
And why are you trying to allocate from this resource in case of
hotplugging memory (and fall back to iomem_resource in case of
failure)?

Either the comment is completely wrong and I don't understand the
logic here, or your code is wrong.


Juergen