linux-kernel - Re: [PATCH 1/4] Staging: rtl8723bs: Replace true with x and false with !x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1513503952.31581.24.camel@perches.com>
Date:   Sun, 17 Dec 2017 01:45:52 -0800
From:   Joe Perches <joe@...ches.com>
To:     Shreeya Patel <shreeya.patel23498@...il.com>,
        gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/4] Staging: rtl8723bs: Replace true with x and false
 with !x

On Sun, 2017-12-17 at 15:07 +0530, Shreeya Patel wrote:
> Replace true and false keywords with "x" and "!x"
> respectively to follow the kernel coding style.
[]
> diff --git a/drivers/staging/rtl8723bs/hal/sdio_ops.c b/drivers/staging/rtl8723bs/hal/sdio_ops.c
[]
> @@ -191,8 +191,8 @@ static u32 sdio_read32(struct intf_hdl *pintfhdl, u32 addr)
>  	rtw_hal_get_hwreg(padapter, HW_VAR_APFM_ON_MAC, &bMacPwrCtrlOn);
>  	if (
>  		((deviceId == WLAN_IOREG_DEVICE_ID) && (offset < 0x100)) ||
> -		(false == bMacPwrCtrlOn) ||
> -		(true == adapter_to_pwrctl(padapter)->bFwCurrentInPSMode)
> +		(!bMacPwrCtrlOn) ||

When you do these sorts of conversions can you
please remove the unnecessary parentheses too?