linux-kernel - [PATCH] lib: add module unload support to sort tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1513504167-4118-1-git-send-email-pravin.shedge4linux@gmail.com>
Date:   Sun, 17 Dec 2017 15:19:27 +0530
From:   Pravin Shedge <pravin.shedge4linux@...il.com>
To:     akpm@...ux-foundation.org, fkostenzer@...e.at,
        andriy.shevchenko@...ux.intel.com, geert@...ux-m68k.org,
        paul.gortmaker@...driver.com, linux-kernel@...r.kernel.org
Cc:     pravin.shedge4linux@...il.com
Subject: [PATCH] lib: add module unload support to sort tests

test_sort.c perform array-based and linked list sort test. Code allows to
compile either as a loadable modules or builtin into the kernel.

Current code is not allow to unload the test_sort.ko module after
successful completion.

This patch add support to unload the "test_sort.ko" module.

Signed-off-by: Pravin Shedge <pravin.shedge4linux@...il.com>
---
 lib/test_sort.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/lib/test_sort.c b/lib/test_sort.c
index d389c1c..26c98d0 100644
--- a/lib/test_sort.c
+++ b/lib/test_sort.c
@@ -13,11 +13,12 @@ static int __init cmpint(const void *a, const void *b)
 
 static int __init test_sort_init(void)
 {
-	int *a, i, r = 1, err = -ENOMEM;
+	int *a, i, r = 1;
+	int err = -EAGAIN; /* Fail will directly unload the module */
 
 	a = kmalloc_array(TEST_LEN, sizeof(*a), GFP_KERNEL);
 	if (!a)
-		return err;
+		return -ENOMEM;
 
 	for (i = 0; i < TEST_LEN; i++) {
 		r = (r * 725861) % 6599;
@@ -26,13 +27,12 @@ static int __init test_sort_init(void)
 
 	sort(a, TEST_LEN, sizeof(*a), cmpint, NULL);
 
-	err = -EINVAL;
 	for (i = 0; i < TEST_LEN-1; i++)
 		if (a[i] > a[i+1]) {
 			pr_err("test has failed\n");
+			err = -EINVAL;
 			goto exit;
 		}
-	err = 0;
 	pr_info("test passed\n");
 exit:
 	kfree(a);
-- 
2.7.4