linux-kernel - Re: [alsa-devel][PATCH v6] ASoC: TSCS42xx: Support Tempo Semiconductor's TSCS42xx audio CODECs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171218195843.c4pp6ntsup2o4l5y@localhost.localdomain>
Date:   Mon, 18 Dec 2017 14:08:32 -0600
From:   Steven Eckhoff <steven.eckhoff.opensource@...il.com>
To:     Charles Keepax <ckeepax@...nsource.cirrus.com>
Cc:     alsa-devel@...a-project.org, Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>, linux-kernel@...r.kernel.org,
        Philippe Ombredanne <pombredanne@...b.com>,
        Takashi Iwai <tiwai@...e.de>
Subject: Re: [alsa-devel][PATCH v6] ASoC: TSCS42xx: Support Tempo
 Semiconductor's TSCS42xx audio CODECs

On Mon, Dec 18, 2017 at 09:50:48AM +0000, Charles Keepax wrote:

> Is this unused?

I apologize I missed this. These were going to be mux controls for two
differential inputs. There are two inputs, but only one can be used at
a time. We have never seen anybody use the second input, so I will
remove the mux controls since it is likely just going to be noise to
anybody configuring the chip through these controls.

> Given all users of this macro use coeff_ram_get and coeff_ram_put
> might it just be worth sticking them in here?

Good point. In the next version the callbacks will be implied through
the use of the macro.

> Other than those two very minor comments, looks ok to me so I
> think you can add:
> 
> Reviewed-by: Charles Keepax <ckeepax@...nsource.cirrus.com>
> 
> Thanks,
> Charles

Thank you so much for your time on this review. It has really helped
improve the driver.