linux-kernel - Re: [alsa-devel][PATCH v6] ASoC: TSCS42xx: Support Tempo Semiconductor's TSCS42xx audio CODECs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171218095048.e5zwla65f2qqmroj@localhost.localdomain>
Date:   Mon, 18 Dec 2017 09:50:48 +0000
From:   Charles Keepax <ckeepax@...nsource.cirrus.com>
To:     Steven Eckhoff <steven.eckhoff.opensource@...il.com>
CC:     <alsa-devel@...a-project.org>, Liam Girdwood <lgirdwood@...il.com>,
        "Mark Brown" <broonie@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>, <linux-kernel@...r.kernel.org>,
        Philippe Ombredanne <pombredanne@...b.com>,
        Takashi Iwai <tiwai@...e.de>
Subject: Re: [alsa-devel][PATCH v6] ASoC: TSCS42xx: Support Tempo
 Semiconductor's TSCS42xx audio CODECs

On Sat, Dec 16, 2017 at 09:54:50PM -0600, Steven Eckhoff wrote:
> Currently there is no support for TSCS42xx audio CODECs.
> 
> Add support for TSCS42xx audio CODECs.
> 
> Acked-by: Philippe Ombredanne <pombredanne@...b.com>
> Signed-off-by: Steven Eckhoff <steven.eckhoff.opensource@...il.com>
> ---
> +/* D2S Input Select */
> +static char const * const d2s_input_select_text[] = {
> +	"Line 1", "Line 2"
> +};
> +
> +static const struct soc_enum d2s_input_select_enum =
> +SOC_ENUM_SINGLE(R_INMODE, FB_INMODE_DS, ARRAY_SIZE(d2s_input_select_text),
> +		d2s_input_select_text);
> +
> +static const struct snd_kcontrol_new d2s_input_mux =
> +SOC_DAPM_ENUM("D2S_IN_MUX", d2s_input_select_enum);
> +

Is this unused?

> +#define COEFF_RAM_CTL(xname, xcount, xhandler_get, xhandler_put, xaddr) \
> +{	.iface = SNDRV_CTL_ELEM_IFACE_MIXER, .name = xname, \
> +	.info = bytes_info_ext, \
> +	.get = xhandler_get, .put = xhandler_put, \

Given all users of this macro use coeff_ram_get and coeff_ram_put
might it just be worth sticking them in here?

> +	.private_value = (unsigned long)&(struct coeff_ram_ctl) { \
> +		.addr = xaddr, \
> +		.bytes_ext = {.max = xcount, }, \
> +	} \
> +}

Other than those two very minor comments, looks ok to me so I
think you can add:

Reviewed-by: Charles Keepax <ckeepax@...nsource.cirrus.com>

Thanks,
Charles