linux-kernel - Re: [PATCH 1/2] dt-bindings: at24: new optional property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75Ve=2NG5egBFCgCXzaaqC7yzZmm=gTe9RZNZO9wVcA6xHw@mail.gmail.com>
Date:   Wed, 20 Dec 2017 00:25:05 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Bartosz Golaszewski <brgl@...ev.pl>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Peter Rosin <peda@...ntia.se>,
        linux-i2c <linux-i2c@...r.kernel.org>,
        devicetree <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] dt-bindings: at24: new optional property - write-protect-gpios

On Tue, Dec 19, 2017 at 6:14 PM, Bartosz Golaszewski <brgl@...ev.pl> wrote:
> AT24 EEPROMs have a write-protect pin, which - when pulled high -
> inhibits writes to the upper quadrant of memory (although it has been
> observed that on some chips it disables writing to the entire memory
> range).
>
> On some boards, this pin is connected to a GPIO and pulled high by
> default, which forces the user to manually change its state before
> writing. On linux this means that we either need to hog the line all
> the time, or set the GPIO value before writing from outside of the
> at24 driver.
>
> Add a new optional property to the device tree binding document, which
> allows to specify the GPIO line to which the write-protect pin is
> connected.
>

> +  - write-protect-gpios: GPIO to which the write-protect pin of the chip is

The rule of thumb is to check what is de facto state of the properties
like this, i.e.

% git grep -n wp-gpio -- Documentation/ | wc -l
14
% git grep -n write-protect-gpio -- Documentation/ | wc -l
0

I think it means something.

-- 
With Best Regards,
Andy Shevchenko