linux-kernel - Re: [PATCH] kobject: fix suppressing modalias in uevents delivered over netlink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89i+OGcnsR5pFiV050a-KtXE=O6zg7+h2RjJQbs82SFL0UQ@mail.gmail.com>
Date:   Tue, 19 Dec 2017 01:12:13 -0800
From:   Eric Dumazet <edumazet@...gle.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Eric Dumazet <eric.dumazet@...il.com>,
        Tariq Toukan <tariqt@...lanox.com>,
        "David S . Miller" <davem@...emloft.net>,
        Komali Katari <komali@...lsio.com>,
        "Luis R. Rodriguez" <mcgrof@...nel.org>,
        Casey Leedom <leedom@...lsio.com>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] kobject: fix suppressing modalias in uevents delivered
 over netlink

On Tue, Dec 19, 2017 at 12:48 AM, Greg Kroah-Hartman
<gregkh@...uxfoundation.org> wrote:
> On Wed, Dec 13, 2017 at 03:21:22PM -0800, Dmitry Torokhov wrote:
>> The commit 4a336a23d619 ("kobject: copy env blob in one go") optimized
>> constructing uevent data for delivery over netlink by using the raw
>> environment buffer, instead of reconstructing it from individual
>> environment pointers. Unfortunately in doing so it broke suppressing
>> MODALIAS attribute for KOBJ_UNBIND events, as the code that suppressed this
>> attribute only adjusted the environment pointers, but left the buffer
>> itself alone. Let's fix it by making sure the offending attribute is
>> obliterated form the buffer as well.
>>
>> Reported-by: Tariq Toukan <tariqt@...lanox.com>
>> Reported-by: Casey Leedom <leedom@...lsio.com>
>> Fixes: 4a336a23d619 ("kobject: copy env blob in one go")
>> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@...il.com>
>> ---
>>  lib/kobject_uevent.c | 16 ++++++++++++----
>>  1 file changed, 12 insertions(+), 4 deletions(-)
>
> Ok, I'm lost here, is this patch still needed for 4.15-final?
>
> And am I supposed to be taking it through my tree as the offending patch
> didn't come from me?  :)

Sorry for that, I sent a patch series (
8ca712c373a462cfa1b62272870b6c2c74aa83f9 )
that was mostly network related stuff (dealing with skbs and all rtnl batching),
and sent it to David before Dmitry patch was visible in David tree.

Yes, we believe fix in zap_modalias_env() is needed.

Thanks.