linux-kernel - Re: [PATCH v9 2/2] media: i2c: Add the ov7740 image sensor driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171219091139.n2wmsj6ydcjntnf3@valkosipuli.retiisi.org.uk>
Date:   Tue, 19 Dec 2017 11:11:39 +0200
From:   Sakari Ailus <sakari.ailus@....fi>
To:     Wenyou.Yang@...rochip.com
Cc:     mchehab@...pensource.com, robh+dt@...nel.org, mark.rutland@....com,
        linux-kernel@...r.kernel.org, Nicolas.Ferre@...rochip.com,
        devicetree@...r.kernel.org, corbet@....net, hverkuil@...all.nl,
        linux-arm-kernel@...ts.infradead.org, linux-media@...r.kernel.org
Subject: Re: [PATCH v9 2/2] media: i2c: Add the ov7740 image sensor driver

Hi Wenyou,

On Tue, Dec 19, 2017 at 02:11:28AM +0000, Wenyou.Yang@...rochip.com wrote:
> Hi Sakari,
> 
> > -----Original Message-----
> > From: Sakari Ailus [mailto:sakari.ailus@....fi]
> > Sent: 2017年12月14日 4:06
> > To: Wenyou Yang - A41535 <Wenyou.Yang@...rochip.com>; Mauro Carvalho
> > Chehab <mchehab@...pensource.com>; Rob Herring <robh+dt@...nel.org>;
> > Mark Rutland <mark.rutland@....com>
> > Cc: linux-kernel@...r.kernel.org; Nicolas Ferre - M43238
> > <Nicolas.Ferre@...rochip.com>; devicetree@...r.kernel.org; Jonathan Corbet
> > <corbet@....net>; Hans Verkuil <hverkuil@...all.nl>; linux-arm-
> > kernel@...ts.infradead.org; Linux Media Mailing List <linux-
> > media@...r.kernel.org>; Songjun Wu <songjun.wu@...rochip.com>
> > Subject: Re: [PATCH v9 2/2] media: i2c: Add the ov7740 image sensor driver
> > 
> > Hi Wenyou,
> > 
> > Wenyou Yang wrote:
> > ...
> > > +static int ov7740_start_streaming(struct ov7740 *ov7740) {
> > > +	int ret;
> > > +
> > > +	if (ov7740->fmt) {
> > > +		ret = regmap_multi_reg_write(ov7740->regmap,
> > > +					     ov7740->fmt->regs,
> > > +					     ov7740->fmt->reg_num);
> > > +		if (ret)
> > > +			return ret;
> > > +	}
> > > +
> > > +	if (ov7740->frmsize) {
> > > +		ret = regmap_multi_reg_write(ov7740->regmap,
> > > +					     ov7740->frmsize->regs,
> > > +					     ov7740->frmsize->reg_num);
> > > +		if (ret)
> > > +			return ret;
> > > +	}
> > > +
> > > +	return __v4l2_ctrl_handler_setup(ov7740->subdev.ctrl_handler);
> > 
> > I believe you're still setting the controls after starting streaming.
> 
> Yes, it sees it does so.
> 
> The OV7740 sensor generates the stream pixel data at the constant frame
> rate, no such start or stop control.

That'd be odd but I guess hardware sometimes is. I'll apply the patches.

Thanks!

-- 
Sakari Ailus
e-mail: sakari.ailus@....fi