linux-kernel - RE: [PATCH v9 2/2] media: i2c: Add the ov7740 image sensor driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <F9F4555C4E01D7469D37975B62D0EFBB8DDA56@CHN-SV-EXMX07.mchp-main.com>
Date:   Tue, 19 Dec 2017 02:11:28 +0000
From:   <Wenyou.Yang@...rochip.com>
To:     <sakari.ailus@....fi>, <mchehab@...pensource.com>,
        <robh+dt@...nel.org>, <mark.rutland@....com>
CC:     <linux-kernel@...r.kernel.org>, <Nicolas.Ferre@...rochip.com>,
        <devicetree@...r.kernel.org>, <corbet@....net>,
        <hverkuil@...all.nl>, <linux-arm-kernel@...ts.infradead.org>,
        <linux-media@...r.kernel.org>
Subject: RE: [PATCH v9 2/2] media: i2c: Add the ov7740 image sensor driver

Hi Sakari,

> -----Original Message-----
> From: Sakari Ailus [mailto:sakari.ailus@....fi]
> Sent: 2017年12月14日 4:06
> To: Wenyou Yang - A41535 <Wenyou.Yang@...rochip.com>; Mauro Carvalho
> Chehab <mchehab@...pensource.com>; Rob Herring <robh+dt@...nel.org>;
> Mark Rutland <mark.rutland@....com>
> Cc: linux-kernel@...r.kernel.org; Nicolas Ferre - M43238
> <Nicolas.Ferre@...rochip.com>; devicetree@...r.kernel.org; Jonathan Corbet
> <corbet@....net>; Hans Verkuil <hverkuil@...all.nl>; linux-arm-
> kernel@...ts.infradead.org; Linux Media Mailing List <linux-
> media@...r.kernel.org>; Songjun Wu <songjun.wu@...rochip.com>
> Subject: Re: [PATCH v9 2/2] media: i2c: Add the ov7740 image sensor driver
> 
> Hi Wenyou,
> 
> Wenyou Yang wrote:
> ...
> > +static int ov7740_start_streaming(struct ov7740 *ov7740) {
> > +	int ret;
> > +
> > +	if (ov7740->fmt) {
> > +		ret = regmap_multi_reg_write(ov7740->regmap,
> > +					     ov7740->fmt->regs,
> > +					     ov7740->fmt->reg_num);
> > +		if (ret)
> > +			return ret;
> > +	}
> > +
> > +	if (ov7740->frmsize) {
> > +		ret = regmap_multi_reg_write(ov7740->regmap,
> > +					     ov7740->frmsize->regs,
> > +					     ov7740->frmsize->reg_num);
> > +		if (ret)
> > +			return ret;
> > +	}
> > +
> > +	return __v4l2_ctrl_handler_setup(ov7740->subdev.ctrl_handler);
> 
> I believe you're still setting the controls after starting streaming.

Yes, it sees it does so.

The OV7740 sensor generates the stream pixel data at the constant frame rate, no such start or stop control. 

> 
> --
> Sakari Ailus
> sakari.ailus@....fi

Wenyou Yang

Download attachment "imx7d-sdb.dtb" of type "application/octet-stream" (46918 bytes)