linux-kernel - Re: [PATCH] pinctrl: axp209: dereference pointer after it's been set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdYDe6NePVw1WCR_CqBYnkje0LiFk5mnH-yJ9s2shD96cA@mail.gmail.com>
Date:   Wed, 20 Dec 2017 09:07:32 +0100
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Quentin Schulz <quentin.schulz@...e-electrons.com>
Cc:     Chen-Yu Tsai <wens@...e.org>,
        Maxime Ripard <maxime.ripard@...e-electrons.com>,
        linux-gpio@...r.kernel.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>,
        linux-sunxi <linux-sunxi@...glegroups.com>,
        Mylene Josserand <mylene.josserand@...e-electrons.com>
Subject: Re: [PATCH] pinctrl: axp209: dereference pointer after it's been set

On Wed, Dec 13, 2017 at 9:55 AM, Quentin Schulz
<quentin.schulz@...e-electrons.com> wrote:

> The number of GPIOs is gotten from a field within the structure
> referenced in the of_device.data but it was actually read before it was
> retrieved, thus it was dereferencing a null pointer.
>
> Set the number of GPIOs after retrieving of_device.data.
>
> Fixes: e1190083b89b ("pinctrl: axp209: add support for AXP813 GPIOs")
>
> Signed-off-by: Quentin Schulz <quentin.schulz@...e-electrons.com>
> Reported-by: Mylène Josserand <mylene.josserand@...e-electrons.com>

Patch applied with the tags for test and ACK.

Yours,
Linus Walleij