linux-kernel - Re: [PATCH] pinctrl: axp209: dereference pointer after it's been set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGb2v65UddT_GYK9eAwhSkubx43z4KrgevHDa=OokJrV3voh6g@mail.gmail.com>
Date:   Thu, 14 Dec 2017 11:05:13 +0800
From:   Chen-Yu Tsai <wens@...e.org>
To:     Mylene JOSSERAND <mylene.josserand@...e-electrons.com>
Cc:     Quentin Schulz <quentin.schulz@...e-electrons.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Chen-Yu Tsai <wens@...e.org>,
        Maxime Ripard <maxime.ripard@...e-electrons.com>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>,
        linux-sunxi <linux-sunxi@...glegroups.com>
Subject: Re: [PATCH] pinctrl: axp209: dereference pointer after it's been set

On Wed, Dec 13, 2017 at 5:20 PM, Mylene JOSSERAND
<mylene.josserand@...e-electrons.com> wrote:
> Hello Quentin,
>
> Le Wed, 13 Dec 2017 09:55:03 +0100,
> Quentin Schulz <quentin.schulz@...e-electrons.com> a écrit :
>
>> The number of GPIOs is gotten from a field within the structure
>> referenced in the of_device.data but it was actually read before it was
>> retrieved, thus it was dereferencing a null pointer.
>>
>> Set the number of GPIOs after retrieving of_device.data.
>>
>> Fixes: e1190083b89b ("pinctrl: axp209: add support for AXP813 GPIOs")
>>
>> Signed-off-by: Quentin Schulz <quentin.schulz@...e-electrons.com>
>> Reported-by: Mylène Josserand <mylene.josserand@...e-electrons.com>
>
> Tested-by: Mylène Josserand <mylene.josserand@...e-electrons.com>

Acked-by: Chen-Yu Tsai <wens@...e.org>