lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20171220100502.a8d23392147340437142efb7@kernel.org> Date: Wed, 20 Dec 2017 10:05:02 +0900 From: Masami Hiramatsu <mhiramat@...nel.org> To: Steven Rostedt <rostedt@...dmis.org> Cc: Ingo Molnar <mingo@...nel.org>, Ian McDonald <ian.mcdonald@...di.co.nz>, Vlad Yasevich <vyasevich@...il.com>, Stephen Hemminger <stephen@...workplumber.org>, Peter Zijlstra <peterz@...radead.org>, Thomas Gleixner <tglx@...utronix.de>, LKML <linux-kernel@...r.kernel.org>, "H . Peter Anvin" <hpa@...or.com>, Gerrit Renker <gerrit@....abdn.ac.uk>, "David S . Miller" <davem@...emloft.net>, Neil Horman <nhorman@...driver.com>, dccp@...r.kernel.org, netdev@...r.kernel.org, linux-sctp@...r.kernel.org, Stephen Rothwell <sfr@...b.auug.org.au> Subject: Re: [PATCH -tip v3 3/6] net: sctp: Add SCTP ACK tracking trace event On Tue, 19 Dec 2017 10:20:24 -0500 Steven Rostedt <rostedt@...dmis.org> wrote: > On Tue, 19 Dec 2017 17:58:25 +0900 > Masami Hiramatsu <mhiramat@...nel.org> wrote: > > > +TRACE_EVENT(sctp_probe, > > + > > + TP_PROTO(const struct sctp_endpoint *ep, > > + const struct sctp_association *asoc, > > + struct sctp_chunk *chunk), > > + > > + TP_ARGS(ep, asoc, chunk), > > + > > + TP_STRUCT__entry( > > + __field(__u64, asoc) > > + __field(__u32, mark) > > + __field(__u16, bind_port) > > + __field(__u16, peer_port) > > + __field(__u32, pathmtu) > > + __field(__u32, rwnd) > > + __field(__u16, unack_data) > > + ), > > + > > + TP_fast_assign( > > + struct sctp_transport *sp; > > + struct sk_buff *skb = chunk->skb; > > + > > + __entry->asoc = (__u64)asoc; > > + __entry->mark = skb->mark; > > + __entry->bind_port = ep->base.bind_addr.port; > > + __entry->peer_port = asoc->peer.port; > > + __entry->pathmtu = asoc->pathmtu; > > + __entry->rwnd = asoc->peer.rwnd; > > + __entry->unack_data = asoc->unack_data; > > + > > + if (trace_sctp_probe_path_enabled()) { > > + list_for_each_entry(sp, &asoc->peer.transport_addr_list, > > + transports) { > > + trace_sctp_probe_path(sp, asoc); > > + } > > + } > > I thought you were going to move this into the code, like I suggested? Ah, I missed to define sp in the block... Thanks, > > -- Steve > > > + ), > > + > > + TP_printk("asoc=%#llx mark=%#x bind_port=%d peer_port=%d pathmtu=%d " > > + "rwnd=%u unack_data=%d", > > + __entry->asoc, __entry->mark, __entry->bind_port, > > + __entry->peer_port, __entry->pathmtu, __entry->rwnd, > > + __entry->unack_data) > > +); > > + -- Masami Hiramatsu <mhiramat@...nel.org>
Powered by blists - more mailing lists