linux-kernel - Re: [PATCH] vfb: fix video mode and line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdXjkY=6=CDMPNFtxtjw8g52ivV-HdnKX3-mao0TPTabMw@mail.gmail.com>
Date:   Wed, 20 Dec 2017 09:26:46 +0100
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Pieter PoroCYon Sluys <pcy@...ional.shitposting.agency>
Cc:     Linux Fbdev development list <linux-fbdev@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
Subject: Re: [PATCH] vfb: fix video mode and line_length being set when loaded

Hi Pieter,

On Wed, Dec 20, 2017 at 1:24 AM, Pieter "PoroCYon" Sluys
<pcy@...ional.shitposting.agency> wrote:
> Currently, when loading the vfb module, the newly created fbdev
> has a line_length of 0, and its video mode would be PSEUDOCOLOR
> regardless of color depth. (The former could be worked around by
> calling the FBIOPUT_VSCREENINFO ioctl with having the FBACTIVIATE_FORCE
> flag set.) This patch automatically sets the line_length correctly,
> and the video mode is derived from the bit depth now as well.

Thanks for your patch!
This bug was introduced in 2002, when converting the driver to the new
internal API.

Please add your "Signed-off-by", cfr.
Documentation/process/submitting-patches.rst.

> --- a/drivers/video/fbdev/vfb.c
> +++ b/drivers/video/fbdev/vfb.c
> @@ -239,8 +239,25 @@ static int vfb_check_var(struct fb_var_screeninfo *var,
>   */
>  static int vfb_set_par(struct fb_info *info)
>  {
> +       switch (info->var.bits_per_pixel) {
> +               case 1:
> +                       info->fix.visual = FB_VISUAL_MONO01;
> +                       break;
> +               case 2:
> +               case 4:

You can drop the tests for 2 and 4, as these are no longer used by the driver.

With the above fixed:
Reviewed-by: Geert Uytterhoeven <geert@...ux-m68k.org>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds