lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Wed, 20 Dec 2017 10:35:11 +0100
From:   Crt Mori <cmo@...exis.com>
To:     Joe Perches <joe@...ches.com>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        Jonathan Cameron <jic23@...nel.org>,
        Ingo Molnar <mingo@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Kees Cook <keescook@...omium.org>,
        Rusty Russell <rusty@...tcorp.com.au>,
        Ian Abbott <abbotti@....co.uk>,
        Larry Finger <Larry.Finger@...inger.net>,
        Niklas Soderlund <niklas.soderlund+renesas@...natech.se>,
        Thomas Gleixner <tglx@...utronix.de>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        linux-kernel@...r.kernel.org, Linux Iio <linux-iio@...r.kernel.org>
Subject: Re: [PATCH v7 1/3] lib: Add strongly typed 64bit int_sqrt

Thanks for suggestions and comments. Respinned v9 with them.

On 19 December 2017 at 17:14, Joe Perches <joe@...ches.com> wrote:
> On Tue, 2017-12-19 at 17:12 +0100, Peter Zijlstra wrote:
>> On Tue, Dec 19, 2017 at 08:09:53AM -0800, Joe Perches wrote:
>> >
>> > I suspect you need to define this as:
>> >
>> > #define int_sqrt64(x) ((u32)int_sqrt(x))
>>
>> What's wrong with using C ?
>
> Duh.  Nothing at all.
>
>> static inline u32 int_sqrt64(u64 x)
>> {
>>       return int_sqrt(x);
>> }

Powered by blists - more mailing lists