lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 20 Dec 2017 15:41:09 +0100 From: Paolo Bonzini <pbonzini@...hat.com> To: Borislav Petkov <bp@...en8.de>, KVM <kvm@...r.kernel.org> Cc: LKML <linux-kernel@...r.kernel.org>, Radim Krčmář <rkrcmar@...hat.com> Subject: Re: [PATCH] kvm/vmx: Use local vmx variable in vmx_get_msr() On 20/12/2017 12:50, Borislav Petkov wrote: > From: Borislav Petkov <bp@...e.de> > > ... just like in vmx_set_msr(). > > No functionality change. > > Signed-off-by: Borislav Petkov <bp@...e.de> > Cc: Paolo Bonzini <pbonzini@...hat.com> > Cc: "Radim Krčmář" <rkrcmar@...hat.com> > --- > arch/x86/kvm/vmx.c | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c > index 023afa0c8887..58be7915da81 100644 > --- a/arch/x86/kvm/vmx.c > +++ b/arch/x86/kvm/vmx.c > @@ -3249,6 +3249,7 @@ static inline bool vmx_feature_control_msr_valid(struct kvm_vcpu *vcpu, > */ > static int vmx_get_msr(struct kvm_vcpu *vcpu, struct msr_data *msr_info) > { > + struct vcpu_vmx *vmx = to_vmx(vcpu); > struct shared_msr_entry *msr; > > switch (msr_info->index) { > @@ -3260,8 +3261,8 @@ static int vmx_get_msr(struct kvm_vcpu *vcpu, struct msr_data *msr_info) > msr_info->data = vmcs_readl(GUEST_GS_BASE); > break; > case MSR_KERNEL_GS_BASE: > - vmx_load_host_state(to_vmx(vcpu)); > - msr_info->data = to_vmx(vcpu)->msr_guest_kernel_gs_base; > + vmx_load_host_state(vmx); > + msr_info->data = vmx->msr_guest_kernel_gs_base; > break; > #endif > case MSR_EFER: > @@ -3287,13 +3288,13 @@ static int vmx_get_msr(struct kvm_vcpu *vcpu, struct msr_data *msr_info) > break; > case MSR_IA32_MCG_EXT_CTL: > if (!msr_info->host_initiated && > - !(to_vmx(vcpu)->msr_ia32_feature_control & > + !(vmx->msr_ia32_feature_control & > FEATURE_CONTROL_LMCE)) > return 1; > msr_info->data = vcpu->arch.mcg_ext_ctl; > break; > case MSR_IA32_FEATURE_CONTROL: > - msr_info->data = to_vmx(vcpu)->msr_ia32_feature_control; > + msr_info->data = vmx->msr_ia32_feature_control; > break; > case MSR_IA32_VMX_BASIC ... MSR_IA32_VMX_VMFUNC: > if (!nested_vmx_allowed(vcpu)) > @@ -3310,7 +3311,7 @@ static int vmx_get_msr(struct kvm_vcpu *vcpu, struct msr_data *msr_info) > return 1; > /* Otherwise falls through */ > default: > - msr = find_msr_entry(to_vmx(vcpu), msr_info->index); > + msr = find_msr_entry(vmx, msr_info->index); > if (msr) { > msr_info->data = msr->data; > break; > Queued, thanks. Paolo
Powered by blists - more mailing lists