linux-kernel - Re: [PATCH RESEND] cpufreq: schedutil: Use idle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1680359.YAEeiLAcPD@aspire.rjw.lan>
Date:   Wed, 20 Dec 2017 15:45:13 +0100
From:   "Rafael J. Wysocki" <rjw@...ysocki.net>
To:     Joel Fernandes <joelaf@...gle.com>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>,
        Len Brown <lenb@...nel.org>,
        Viresh Kumar <viresh.kumar@...aro.org>,
        Ingo Molnar <mingo@...hat.com>,
        Juri Lelli <juri.lelli@...hat.com>,
        Patrick Bellasi <patrick.bellasi@....com>,
        Chris Redpath <Chris.Redpath@....com>,
        Steve Muckle <smuckle@...gle.com>,
        Dietmar Eggemann <dietmar.eggemann@....com>,
        Vincent Guittot <vincent.guittot@...aro.org>,
        Morten Ramussen <morten.rasmussen@....com>,
        Frederic Weisbecker <fweisbec@...il.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Saravana Kannan <skannan@...cinc.com>,
        Vikram Mulukutla <markivx@...eaurora.org>,
        Rohit Jain <rohit.k.jain@...cle.com>,
        Atish Patra <atish.patra@...cle.com>,
        Josef Bacik <jbacik@...com>, Rik van Riel <riel@...hat.com>,
        EAS Dev <eas-dev@...ts.linaro.org>
Subject: Re: [PATCH RESEND] cpufreq: schedutil: Use idle_calls counter of the remote CPU

On Tuesday, December 19, 2017 8:32:09 PM CET Joel Fernandes wrote:
> On Tue, Dec 19, 2017 at 10:48 AM, Peter Zijlstra <peterz@...radead.org> wrote:
> > On Tue, Dec 19, 2017 at 09:47:12AM -0800, Joel Fernandes wrote:
> >> Since the recent remote cpufreq callback work, its possible that a cpufreq
> >> update is triggered from a remote CPU. For single policies however, the current
> >> code uses the local CPU when trying to determine if the remote sg_cpu entered
> >> idle or is busy. This is incorrect. To remedy this, compare with the nohz tick
> >> idle_calls counter of the remote CPU.
> >>
> >> Acked-by: Viresh Kumar <viresh.kumar@...aro.org>
> >> Signed-off-by: Joel Fernandes <joelaf@...gle.com>
> >
> > Acked-by: Peter Zijlstra (Intel) <peterz@...radead.org>
> 
> Sweet!

OK, so any chance to get a Fixes: tag for the patch?

Thanks,
Rafael