linux-kernel - Re: [PATCH v4 1/2] dm-unstripe: unstripe RAID 0/dm-striped device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 20 Dec 2017 11:09:47 -0500
From:   Mike Snitzer <snitzer@...hat.com>
To:     kbuild test robot <lkp@...el.com>
Cc:     Scott Bauer <scott.bauer@...el.com>, kbuild-all@...org,
        dm-devel@...hat.com, agk@...hat.com, linux-kernel@...r.kernel.org,
        keith.busch@...el.com, jonathan.derrick@...el.com
Subject: Re: [PATCH v4 1/2] dm-unstripe: unstripe RAID 0/dm-striped device

On Wed, Dec 20 2017 at  5:21am -0500,
kbuild test robot <lkp@...el.com> wrote:

> Hi Scott,
> 
> I love your patch! Yet something to improve:
> 
> [auto build test ERROR on dm/for-next]
> [also build test ERROR on v4.15-rc4]
> [cannot apply to next-20171220]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
> 
> url:    https://github.com/0day-ci/linux/commits/Scott-Bauer/dm-unstripe/20171220-121845
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git for-next
> config: arm-allyesconfig (attached as .config)
> compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0
> reproduce:
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # save the attached .config to linux build tree
>         make.cross ARCH=arm 
> 
> All errors (new ones prefixed by >>):
> 
>    drivers/md/dm-unstripe.o: In function `set_ctr':
> >> dm-unstripe.c:(.text+0x438): undefined reference to `__aeabi_uldivmod'
>    dm-unstripe.c:(.text+0x450): undefined reference to `__aeabi_uldivmod'
> 
> ---
> 0-DAY kernel test infrastructure                Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all                   Intel Corporation


These reports are no longer relevant given the code has changed since
v4. In particular these 64-bit divide and mod in v4 no longer exist:

+       u64 tot_sec, mod;
...
+       tot_sec = i_size_read(bbdev->bd_inode) >> SECTOR_SHIFT;
+       mod = tot_sec % target->chunk_sectors;
+
+       if (ti->len == 1)
+               ti->len = (tot_sec / tot_drives) - mod;