linux-kernel - Re: [PATCH 1/2] dt-bindings: phy: ti-pipe3: Add dt binding to use USB3 PHY for PCIe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171220205511.lqi2ijggfqeel6tu@rob-hp-laptop>
Date:   Wed, 20 Dec 2017 14:55:11 -0600
From:   Rob Herring <robh@...nel.org>
To:     Kishon Vijay Abraham I <kishon@...com>
Cc:     Mark Rutland <mark.rutland@....com>, devicetree@...r.kernel.org,
        linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
        nsekhar@...com
Subject: Re: [PATCH 1/2] dt-bindings: phy: ti-pipe3: Add dt binding to use
 USB3 PHY for PCIe

On Tue, Dec 19, 2017 at 03:15:39PM +0530, Kishon Vijay Abraham I wrote:
> DRA72 uses USB3 PHY for the 2nd lane of PCIE. Add dt bindings property
> to indicate if the USB3 PHY should be used for 2nd lane of PCIe.
> 
> Signed-off-by: Kishon Vijay Abraham I <kishon@...com>
> ---
>  Documentation/devicetree/bindings/phy/ti-phy.txt | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/phy/ti-phy.txt b/Documentation/devicetree/bindings/phy/ti-phy.txt
> index cd13e6157088..907a046e794b 100644
> --- a/Documentation/devicetree/bindings/phy/ti-phy.txt
> +++ b/Documentation/devicetree/bindings/phy/ti-phy.txt
> @@ -93,6 +93,8 @@ Optional properties:
>     register that contains the SATA_PLL_SOFT_RESET bit. Only valid for sata_phy.
>   - syscon-pcs : phandle/offset pair. Phandle to the system control module and the
>     register offset to write the PCS delay value.
> + - "ti,configure-as-pcie" : property to indicate if the PHY should be
> +   configured as PCIE PHY.

This is not that uncommon as PCIe, 10Gb eth, USB3, SATA are all very 
electrically similar and the same phy can drive all of them AIUI. The DT 
already contains the necessary information too because you have a phys 
property creating a link to PCI host. The problem is either the client 
side would need to set the mode or you'd have to search all "phys" 
properties to find the link. There's already a DT function to iterate 
thru all named properties.

Rob