linux-kernel - Re: [PATCH v1 1/1] ASoC: rsnd: ssi: Fix issue in dma data address assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 21 Dec 2017 01:16:39 -0800
From:   Jiada Wang <jiada_wang@...tor.com>
To:     Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
CC:     <lgirdwood@...il.com>, <broonie@...nel.org>, <perex@...ex.cz>,
        <tiwai@...e.com>, <alsa-devel@...a-project.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1 1/1] ASoC: rsnd: ssi: Fix issue in dma data address
 assignment

Hi Morimoto-san

On 12/20/2017 11:39 PM, Kuninori Morimoto wrote:
> Hi Jiada
>
>> diff --git a/arch/arm64/boot/dts/renesas/salvator-common.dtsi
>> b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
>> index a298df7..16f3214 100644
>> --- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi
>> +++ b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
>> @@ -94,14 +94,24 @@
>>          };
>>
>>          rsnd_ak4613: sound {
>> -               compatible = "simple-audio-card";
>> +               compatible = "simple-scu-audio-card";
>>
>>                  simple-audio-card,format = "left_j";
>>                  simple-audio-card,bitclock-master =<&sndcpu>;
>>                  simple-audio-card,frame-master =<&sndcpu>;
>>
>> -               sndcpu: simple-audio-card,cpu {
>> -                       sound-dai =<&rcar_sound>;
>> +               simple-audio-card,prefix = "ak4613";
>> +                simple-audio-card,routing =
>> +                        "ak4613 Playback", "DAI0 Playback",
>> +                        "DAI0 Capture", "ak4613 Capture",
>> +                        "ak4613 Playback", "DAI1 Playback";
>> +
>> +               sndcpu: simple-audio-card,cpu@0 {
>> +                       sound-dai =<&rcar_sound 0>;
>> +               };
>> +
>> +               simple-audio-card,cpu@1 {
>> +                       sound-dai =<&rcar_sound 1>;
>>                  };
>>
>>                  sndcodec: simple-audio-card,codec {
>> @@ -517,7 +527,7 @@
>>          pinctrl-names = "default";
>>
>>          /* Single DAI */
>> -       #sound-dai-cells =<0>;
>> +       #sound-dai-cells =<1>;
>>
>>          /* audio_clkout0/1/2/3 */
>>   #clock-cells =<1>;
>> @@ -549,6 +559,9 @@
>>                          playback =<&ssi0&src0&dvc0>;
>>                          capture  =<&ssi1&src1&dvc1>;
>>                  };
>> +               dai1 {
>> +                       playback =<&ssi0>;
>> +               };
>>          };
>>   };
>>
>> playing with dai1 will have issue.
> I guess so because you are using strange settings...
> What do you want to do ?
this is just an example setting to reproduce the issue with current 
mainline kernel,

We have enabled TDM Split and Ex-Split mode in our kernel,
and SSI(U)'s dma address diffs based on the BUSIF it is using,
so have a single dma data struct per rsnd_ssi will cause issue when
SSI isn't working with BUSIF0.

Do you have any suggestion to address this issue?


Thanks,
Jiada
> Best regards
> ---
> Kuninori Morimoto