linux-kernel - Re: [PATCH] iio: adc: add driver for ti adc081s/adc101s/adc121s

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOFm3uFn+z+ouTNM5HOw3FEgBhW3T4WiPRwtPuwapq_m4wHWKQ@mail.gmail.com>
Date:   Sat, 23 Dec 2017 15:13:03 +0100
From:   Philippe Ombredanne <pombredanne@...b.com>
To:     Milan Stevanovic <milan.o.stevanovic@...il.com>
Cc:     Jonathan Cameron <jic23@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>, linux-iio@...r.kernel.org
Subject: Re: [PATCH] iio: adc: add driver for ti adc081s/adc101s/adc121s

Milan,

On Sat, Dec 23, 2017 at 12:19 AM, Milan Stevanovic
<milan.o.stevanovic@...il.com> wrote:
> Signed-off-by: Milan Stevanovic <milan.o.stevanovic@...il.com>

<snip>

May be it is just me, but you may be missing a commit message?

<snip>

> --- /dev/null
> +++ b/drivers/iio/adc/ti-adc081s.c
> @@ -0,0 +1,239 @@
> +/*
> + * TI ADC081S/ADC101S/ADC121S 8/10/12-bit ADC driver
> + *
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.

Could you consider using an SPDX tag here as documented by Thomas in
this patch set [1] ?
This is the new thing for this end of of year and a must have for 2018!

[1] https://lkml.org/lkml/2017/12/4/934

-- 
Cordially
Philippe Ombredanne