linux-kernel - Re: [PATCH v2] zram: better utilization of zram swap space

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 29 Dec 2017 16:26:56 +0900
From:   Minchan Kim <minchan@...nel.org>
To:     Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>,
        gopi.st@...sung.com
Cc:     Gopi Sai Teja <gopi.st@...sung.com>, ngupta@...are.org,
        linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        v.narang@...sung.com, pankaj.m@...sung.com, a.sahrawat@...sung.com,
        prakash.a@...sung.com, himanshu.sh@...sung.com,
        lalit.mohan@...sung.com
Subject: Re: [PATCH v2] zram: better utilization of zram swap space

On Thu, Dec 28, 2017 at 09:00:04AM +0900, Minchan Kim wrote:
> On Wed, Dec 27, 2017 at 04:10:56PM +0900, Sergey Senozhatsky wrote:
> > On (12/27/17 15:29), Minchan Kim wrote:
> > > On Fri, Dec 22, 2017 at 04:00:06PM +0530, Gopi Sai Teja wrote:
> > > > 75% of the PAGE_SIZE is not a correct threshold to store uncompressed
> > > 
> > > Please describe it in detail that why current threshold is bad in that
> > > memory efficiency point of view.
> > > 
> > > > pages in zs_page as this must be changed if the maximum pages stored
> > > > in zspage changes. Instead using zs classes, we can set the correct
> > > 
> > > Also, let's include the pharase Sergey pointed out in this description.
> > > 
> > > It's not a good idea that zram need to know allocator's implementation
> > > with harded value like 75%.
> > 
> > so I don't like that, basically, my work and my findings are
> > now submitted by someone else without even crediting my work.
> > not to mention that I like my commit message much better.
> > 
> > 	-ss
> 
> Gopi Sai Teja, please discuss with Sergey about patch credit.

Hi Gopi Sai Teja,

Now I read previous thread at v1 carefully, I found Sergey already
sent a patch long time ago which is almost same one I suggested.
And he told he will send a patch soon so I want to wait his patch.
We are approaching rc6 now so it's not urgent.

Sergey, sorry for missing your patch at that time.
Could you resend your patch when you have a time? Please think
over better name of the function "zs_get_huge_class_size_watermark"

Thanks.