[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date: Mon, 1 Jan 2018 20:38:50 +0800
From: Axel Lin <axel.lin@...ics.com>
To: Mark Brown <broonie@...nel.org>
Cc: Erick Chen <erick.chen@...eadtrum.com>,
Baolin Wang <baolin.wang@...eadtrum.com>,
Liam Girdwood <lgirdwood@...il.com>,
linux-kernel@...r.kernel.org, Axel Lin <axel.lin@...ics.com>
Subject: [PATCH v2] regulator: sc2731: Fix defines for SC2731_WR_UNLOCK and SC2731_PWR_WR_PROT_VALUE
The defines for SC2731_WR_UNLOCK and SC2731_PWR_WR_PROT_VALUE makes
regmap_write() call looks strange because it takes reg parameter fist
then val.
Base on Erick's suggestion to define SC2731_PWR_WR_PROT and
SC2731_WR_UNLOCK_VALUE instead.
Signed-off-by: Axel Lin <axel.lin@...ics.com>
---
drivers/regulator/sc2731-regulator.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/regulator/sc2731-regulator.c b/drivers/regulator/sc2731-regulator.c
index 794fcd504b3d..eb2bdf060b7b 100644
--- a/drivers/regulator/sc2731-regulator.c
+++ b/drivers/regulator/sc2731-regulator.c
@@ -13,8 +13,8 @@
/*
* SC2731 regulator lock register
*/
-#define SC2731_PWR_WR_PROT_VALUE 0xf0c
-#define SC2731_WR_UNLOCK 0x6e7f
+#define SC2731_PWR_WR_PROT 0xf0c
+#define SC2731_WR_UNLOCK_VALUE 0x6e7f
/*
* SC2731 enable register
@@ -203,8 +203,8 @@ static struct regulator_desc regulators[] = {
static int sc2731_regulator_unlock(struct regmap *regmap)
{
- return regmap_write(regmap, SC2731_PWR_WR_PROT_VALUE,
- SC2731_WR_UNLOCK);
+ return regmap_write(regmap, SC2731_PWR_WR_PROT,
+ SC2731_WR_UNLOCK_VALUE);
}
static int sc2731_regulator_probe(struct platform_device *pdev)
--
2.14.1
Powered by blists - more mailing lists