linux-kernel - Re: [PATCH v2] regulator: sc2731: Fix defines for SC2731_WR_UNLOCK and SC2731_PWR_WR_PROT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 3 Jan 2018 14:32:52 +0800
From:   Erick Chen <erick.chen@...eadtrum.com>
To:     Axel Lin <axel.lin@...ics.com>
CC:     Mark Brown <broonie@...nel.org>,
        Baolin Wang <baolin.wang@...eadtrum.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] regulator: sc2731: Fix defines for SC2731_WR_UNLOCK
 and SC2731_PWR_WR_PROT_VALUE

Hi Axel,

On 一,  1月 01, 2018 at 08:38:50下午 +0800, Axel Lin wrote:
> The defines for SC2731_WR_UNLOCK and SC2731_PWR_WR_PROT_VALUE makes
> regmap_write() call looks strange because it takes reg parameter fist
> then val.
> Base on Erick's suggestion to define SC2731_PWR_WR_PROT and
> SC2731_WR_UNLOCK_VALUE instead.
> 
> Signed-off-by: Axel Lin <axel.lin@...ics.com>

Reviewed-by: Erick Chen <erick.chen@...eadtrum.com>

>