linux-kernel - Re: [PATCH v3] drm/ttm: check the return value of kzalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 2 Jan 2018 15:33:51 +0100
From:   Christian König <christian.koenig@....com>
To:     Xiongwei Song <sxwjean@...il.com>, Hongbo.He@....com,
        airlied@...ux.ie
Cc:     dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] drm/ttm: check the return value of kzalloc

Am 02.01.2018 um 14:24 schrieb Xiongwei Song:
> In the function ttm_page_alloc_init, kzalloc call is made for variable
> _manager, we need to check its return value, it may return NULL.
>
> Signed-off-by: Xiongwei Song <sxwjean@...il.com>

Reviewed-by: Christian König <christian.koenig@....com>

Going to pick that up for the next release.

Thanks,
Christian.

> ---
> v2->v3: delete goto expression
> v1->v2: delete kfree _manager
> ---
>   drivers/gpu/drm/ttm/ttm_page_alloc.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/ttm/ttm_page_alloc.c b/drivers/gpu/drm/ttm/ttm_page_alloc.c
> index b5ba6441489f..5d252fb27a82 100644
> --- a/drivers/gpu/drm/ttm/ttm_page_alloc.c
> +++ b/drivers/gpu/drm/ttm/ttm_page_alloc.c
> @@ -1007,6 +1007,8 @@ int ttm_page_alloc_init(struct ttm_mem_global *glob, unsigned max_pages)
>   	pr_info("Initializing pool allocator\n");
>   
>   	_manager = kzalloc(sizeof(*_manager), GFP_KERNEL);
> +	if (!_manager)
> +		return -ENOMEM;
>   
>   	ttm_page_pool_init_locked(&_manager->wc_pool, GFP_HIGHUSER, "wc", 0);
>