linux-kernel - RE: [PATCH v8 1/2] tpm_tis: Move ilb_base_addr to tpm_tis

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5FFFAD06ADE1CA4381B3F0F7C6AF582898A05E@ORSMSX109.amr.corp.intel.com>
Date:   Tue, 2 Jan 2018 05:31:30 +0000
From:   "Shaikh, Azhar" <azhar.shaikh@...el.com>
To:     "Shaikh, Azhar" <azhar.shaikh@...el.com>,
        Jason Gunthorpe <jgg@...pe.ca>
CC:     "jarkko.sakkinen@...ux.intel.com" <jarkko.sakkinen@...ux.intel.com>,
        "peterhuewe@....de" <peterhuewe@....de>,
        "linux-security-module@...r.kernel.org" 
        <linux-security-module@...r.kernel.org>,
        "linux-integrity@...r.kernel.org" <linux-integrity@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v8 1/2] tpm_tis: Move ilb_base_addr to tpm_tis_data



>-----Original Message-----
>From: linux-integrity-owner@...r.kernel.org [mailto:linux-integrity-
>owner@...r.kernel.org] On Behalf Of Shaikh, Azhar
>Sent: Monday, January 1, 2018 9:02 PM
>To: Jason Gunthorpe <jgg@...pe.ca>
>Cc: jarkko.sakkinen@...ux.intel.com; peterhuewe@....de; linux-security-
>module@...r.kernel.org; linux-integrity@...r.kernel.org; linux-
>kernel@...r.kernel.org
>Subject: RE: [PATCH v8 1/2] tpm_tis: Move ilb_base_addr to tpm_tis_data
>
>
>
>>-----Original Message-----
>>From: Jason Gunthorpe [mailto:jgg@...pe.ca]
>>Sent: Monday, January 1, 2018 8:41 PM
>>To: Shaikh, Azhar <azhar.shaikh@...el.com>
>>Cc: jarkko.sakkinen@...ux.intel.com; peterhuewe@....de; linux-security-
>>module@...r.kernel.org; linux-integrity@...r.kernel.org; linux-
>>kernel@...r.kernel.org
>>Subject: Re: [PATCH v8 1/2] tpm_tis: Move ilb_base_addr to tpm_tis_data
>>
>>On Mon, Jan 01, 2018 at 08:05:43PM -0800, Azhar Shaikh wrote:
>>
>>> -	return tpm_chip_register(chip);
>>> +	rc = tpm_chip_register(chip);
>>> +	if (rc && is_bsw())
>>> +		iounmap(priv->ilb_base_addr);
>>> +
>>> +	return rc;
>>>  out_err:
>>>  	tpm_tis_remove(chip);
>>> +	if (is_bsw())
>>> +		iounmap(priv->ilb_base_addr);
>>> +
>>>  	return rc;
>>>  }
>>
>>I thought you were resending this to fix the above, why is is it still wonky?
>>
>
>Oh! I fixed it in the second patch ("tpm: Keep CLKRUN enabled throughout
>the duration of transmit_cmd()"). Should have fixed in this patch instead. My
>bad, didn't see it was introduced in this patch. I thought it was part of second
>patch. Will fix this.
>

On checking, the ops->clk_enable is not still introduced yet. It is introduced in the second patch. The cleanup is done in the next patch.
So do you want me to still fix this here?

>>Jason

Regards,
Azhar Shaikh