linux-kernel - Re: [PATCH][crypto-next] crypto: inside-secure - make function safexcel_try_push

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180103083811.GA21727@kwain>
Date:   Wed, 3 Jan 2018 09:38:11 +0100
From:   Antoine Tenart <antoine.tenart@...e-electrons.com>
To:     Colin King <colin.king@...onical.com>
Cc:     Antoine Tenart <antoine.tenart@...e-electrons.com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        "David S . Miller" <davem@...emloft.net>,
        linux-crypto@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH][crypto-next] crypto: inside-secure - make function
 safexcel_try_push_requests static

Hi Colin,

On Tue, Jan 02, 2018 at 02:34:10PM +0000, Colin King wrote:
>  
>  /* Called with ring's lock taken */
> -int safexcel_try_push_requests(struct safexcel_crypto_priv *priv, int ring,
> -			       int reqs)
> +static int safexcel_try_push_requests(struct safexcel_crypto_priv *priv,
> +				     int ring, int reqs)

Alignment should match open parenthesis, one space is missing. Otherwise,
looks good to me.

Thanks!
Antoine

-- 
Antoine Ténart, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com