linux-kernel - Re: [PATCH] nvme: check ctrl.tagset before start ns scan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ef7f1b69-c042-60f7-6bd3-6dd4c4d73b90@grimberg.me>
Date:   Wed, 3 Jan 2018 11:37:45 +0200
From:   Sagi Grimberg <sagi@...mberg.me>
To:     Jianchao Wang <jianchao.w.wang@...cle.com>, keith.busch@...el.com,
        axboe@...com, hch@....de
Cc:     linux-nvme@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] nvme: check ctrl.tagset before start ns scan

Hi Jianchao,

> ctrl.tagset maybe NULL due to failure of io queue setup or blk-mq
> tagset allocation in nvme_reset_work. Then panic would come up.
> To fix this, just add ctrl.tagset check in nvme_scan_work.

This came up before (and forgotten...) I think we should not
have state indicators other than ctrl->state.

How about instead we add a new state NVME_CTRL_ADMIN_LIVE when we have
no I/O queues.