linux-kernel - Re: [PATCH] nvme: check ctrl.tagset before start ns scan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a5b2d8a9-5241-28a3-5f8d-6a9ba0e6ac7d@oracle.com>
Date:   Thu, 4 Jan 2018 12:01:54 +0800
From:   "jianchao.wang" <jianchao.w.wang@...cle.com>
To:     Sagi Grimberg <sagi@...mberg.me>, keith.busch@...el.com,
        axboe@...com, hch@....de
Cc:     linux-nvme@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] nvme: check ctrl.tagset before start ns scan

Hi sagi

Many thanks for your kindly response.

On 01/03/2018 05:37 PM, Sagi Grimberg wrote:
> Hi Jianchao,
> 
>> ctrl.tagset maybe NULL due to failure of io queue setup or blk-mq
>> tagset allocation in nvme_reset_work. Then panic would come up.
>> To fix this, just add ctrl.tagset check in nvme_scan_work.
> 
> This came up before (and forgotten...) I think we should not
> have state indicators other than ctrl->state.
> 
> How about instead we add a new state NVME_CTRL_ADMIN_LIVE when we have
> no I/O queues.
> 
Yes, that's a good idea that add a new state NMVE_CTRL_ADMIN_LIVE to indicate
only the admin queue live. On the other hand, add a sanity checking that whether
ctrl->tagset is NULL is also necessary. :)

Thanks
Jianchao