linux-kernel - [PATCH] optee: fix the dead loop problem when there is signal pending

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 4 Jan 2018 03:30:50 +0800
From:   Zeng Tao <prime.zeng@...ilicon.com>
To:     <jens.wiklander@...aro.org>
CC:     <linux-kernel@...r.kernel.org>, <tee-dev@...ts.linaro.org>
Subject: [PATCH] optee: fix the dead loop problem when there is signal pending

when the current process is doing a rpc call from optee, and if there
is a signal pending on the process, it will enter dead loop if the
tee-supplicant is working correctly, fix the problem by breaking out
the loop when the rpc job is finished.

Signed-off-by: Zeng Tao <prime.zeng@...ilicon.com>
---
 drivers/tee/optee/supp.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/tee/optee/supp.c b/drivers/tee/optee/supp.c
index b4ea067..170dedb 100644
--- a/drivers/tee/optee/supp.c
+++ b/drivers/tee/optee/supp.c
@@ -107,6 +107,13 @@ u32 optee_supp_thrd_req(struct tee_context *ctx, u32 func, size_t num_params,
 		mutex_unlock(&supp->ctx_mutex);
 		if (interruptable)
 			break;
+
+		/*
+		 * if there is signal pending, and the supplicant has finished
+		 * the rpc job, we need to break out the loop
+		 */
+		if (try_wait_for_completion(&supp->data_from_supp))
+			break;
 	}
 
 	ret = supp->ret;
-- 
2.7.4