linux-kernel - Re: [PATCH -next] irqchip/ompic: fix return value check in ompic_of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 3 Jan 2018 23:41:29 +0900
From:   Stafford Horne <shorne@...il.com>
To:     Wei Yongjun <weiyongjun1@...wei.com>
Cc:     Jonas Bonn <jonas@...thpole.se>,
        Stefan Kristiansson <stefan.kristiansson@...nalahti.fi>,
        Thomas Gleixner <tglx@...utronix.de>,
        Jason Cooper <jason@...edaemon.net>,
        Marc Zyngier <marc.zyngier@....com>,
        openrisc@...ts.librecores.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] irqchip/ompic: fix return value check in
 ompic_of_init()

On Tue, Jan 02, 2018 at 11:47:19AM +0000, Wei Yongjun wrote:
> In case of error, the function ioremap() returns NULL pointer not
> ERR_PTR(). The IS_ERR() test in the return value check should be
> replaced with NULL test.

Thanks, I am not sure why I was using the *ERR*() macros.  2 questions:

 - How did you notice this?
 - Should I pull this in through my tree or do you have another route? i.e.
   Marc?

> Fixes: 9b54470afd83 ("irqchip: add initial support for ompic")
> Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>

Acked-by: Stafford Horne <shorne@...il.com>

-Stafford

> ---
>  drivers/irqchip/irq-ompic.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/irqchip/irq-ompic.c b/drivers/irqchip/irq-ompic.c
> index cf6d0c4..400b119 100644
> --- a/drivers/irqchip/irq-ompic.c
> +++ b/drivers/irqchip/irq-ompic.c
> @@ -171,9 +171,9 @@ static int __init ompic_of_init(struct device_node *node,
>  
>  	/* Setup the device */
>  	ompic_base = ioremap(res.start, resource_size(&res));
> -	if (IS_ERR(ompic_base)) {
> +	if (!ompic_base) {
>  		pr_err("ompic: unable to map registers");
> -		return PTR_ERR(ompic_base);
> +		return -ENOMEM;
>  	}
>  
>  	irq = irq_of_parse_and_map(node, 0);
>