linux-kernel - RE: [PATCH -next] irqchip/ompic: fix return value check in ompic_of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6AADFAC011213A4C87B956458587ADB40131FAB5@dggemi507-mbx.china.huawei.com>
Date:   Thu, 4 Jan 2018 03:56:41 +0000
From:   "weiyongjun (A)" <weiyongjun1@...wei.com>
To:     Stafford Horne <shorne@...il.com>
CC:     Jonas Bonn <jonas@...thpole.se>,
        Stefan Kristiansson <stefan.kristiansson@...nalahti.fi>,
        Thomas Gleixner <tglx@...utronix.de>,
        Jason Cooper <jason@...edaemon.net>,
        Marc Zyngier <marc.zyngier@....com>,
        "openrisc@...ts.librecores.org" <openrisc@...ts.librecores.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH -next] irqchip/ompic: fix return value check in
 ompic_of_init()

On Wed, Jan 03, 2018 10:41 PM, Stafford Horne wrote:
> On Tue, Jan 02, 2018 at 11:47:19AM +0000, Wei Yongjun wrote:
> > In case of error, the function ioremap() returns NULL pointer not
> > ERR_PTR(). The IS_ERR() test in the return value check should be
> > replaced with NULL test.
> 
> Thanks, I am not sure why I was using the *ERR*() macros.  2 questions:
> 
>  - How did you notice this?

This is detected by Coccinelle semantic patch. 

>  - Should I pull this in through my tree or do you have another route? i.e.
>    Marc?

Feel free to pull this through your tree.