linux-kernel - Re: [PATCH -next] irqchip/ompic: fix return value check in ompic_of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <68282353-1c44-3d0f-32ec-23934fc19686@arm.com>
Date:   Thu, 4 Jan 2018 09:57:42 +0000
From:   Marc Zyngier <marc.zyngier@....com>
To:     "weiyongjun (A)" <weiyongjun1@...wei.com>,
        Stafford Horne <shorne@...il.com>
Cc:     Jonas Bonn <jonas@...thpole.se>,
        Stefan Kristiansson <stefan.kristiansson@...nalahti.fi>,
        Thomas Gleixner <tglx@...utronix.de>,
        Jason Cooper <jason@...edaemon.net>,
        "openrisc@...ts.librecores.org" <openrisc@...ts.librecores.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] irqchip/ompic: fix return value check in
 ompic_of_init()

On 04/01/18 03:56, weiyongjun (A) wrote:
> On Wed, Jan 03, 2018 10:41 PM, Stafford Horne wrote:
>> On Tue, Jan 02, 2018 at 11:47:19AM +0000, Wei Yongjun wrote:
>>> In case of error, the function ioremap() returns NULL pointer not
>>> ERR_PTR(). The IS_ERR() test in the return value check should be
>>> replaced with NULL test.
>>
>> Thanks, I am not sure why I was using the *ERR*() macros.  2 questions:
>>
>>  - How did you notice this?
> 
> This is detected by Coccinelle semantic patch. 
> 
>>  - Should I pull this in through my tree or do you have another route? i.e.
>>    Marc?
> 
> Feel free to pull this through your tree.

That's for me to say... I'll take it.


Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...